-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: EKS Protection #61
Conversation
ryanjpayne
commented
Aug 13, 2024
- Add resources and documentation to support CrowdStrike EKS Protection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test in the .taskcat.yaml
to deploy this new use case in addition to the review comments.
- Arn | ||
|
||
# CodeBuild Project to deploy Falcon Operator and Sensor | ||
EKSCodeBuild: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommendation: CodeBuild project should specify an EncryptionKey value
Add exemption with valid reason if the project cannot be encrypted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which linter does this flag apply? I do not see it in cfnlint or checkov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but the default cmk will suffice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming from cfn_nag. Could you please add an exception to avoid flagging this in future. No value for EncryptionKey
defaults to the managed CMK for Amazon Simple Storage Service (Amazon S3)
Need to add taskcat ssm params:
Retrieve Docker API Token from falcon console>cloud accounts registration>kubernetes
|
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
@ryanjpayne since there are no default values, required parameters from failure reason below need to be added to all tests in the .taskcat.yml file. Failure reason:
|
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
- id: CKV_AWS_109 | ||
comment: IAM PassRole action is constrained by resource ARN. | ||
- id: CKV_AWS_111 | ||
comment: IAM PassRole action is constrained by resource ARN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not see iam:PassRole
in this policy. What is the need for this exception?
templates/eks-protection-stack.yml
Outdated
Name: !Ref CodeBuildProjectName | ||
ServiceRole: !Sub arn:${AWS::Partition}:iam::${AWS::AccountId}:role/${CodeBuildRoleName} | ||
Source: | ||
Location: !Sub '${StagingS3Bucket}/${SourceS3BucketNamePrefix}/codebuild/codebuild.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryanjpayne This needs to be fixed to match with the new file location?
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
d951cce
to
ed64e7a
Compare
Static analysis has failed. Please review and take action as appropriate. |
Static analysis has failed. Please review and take action as appropriate. |
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E test has completed with errors. If you are an external contributor, please contact the project maintainers for more information.
/do-e2e-tests |
End to end test has been scheduled |
E2E tests in progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests completed successfully